Skip to content

Add a regression test for airq integration stalling #155511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Add a regression test for airq integration stalling #155511

wants to merge 1 commit into from

Conversation

@Sibgatulin
Copy link
Contributor

Proposed change

The stalling was (hopefully) fixed in homeassistant==2025.10.3 with the bump to aioairq==0.4.7.
This PR introduces a regression test that captures the stalling behaviour <2025.10.3.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue: airq integration stops updating #82077
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Sibgatulin
Add a regression test for airq integration stalling
a832de1 
Fixed in homeassistant==2025.10.3 and aioairq==0.4.7
@home-assistant
Copy link

Hey there @dl2080, mind taking a look at this pull request as it has been labeled with an integration (airq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airq can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airq Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

abmantis
abmantis requested changes Oct 30, 2025
View reviewed changes
tests/components/airq/test_integration_stalling_regression.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be in test_init.py, to be consistent with most of the codebase.
Also, we should not interact directly with the coordinator or other integration internals: https://developers.home-assistant.io/docs/development_testing/#writing-tests-for-integrations
Can we refactor this to avoid interacting with the internals?

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft October 30, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abmantis abmantis abmantis requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

by-code-owner cla-signed code-quality Hacktoberfest has-tests integration: airq Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sibgatulin @abmantis